Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new colors referenced by applab dark theme #27792

Merged
merged 1 commit into from Apr 1, 2019
Merged

add new colors referenced by applab dark theme #27792

merged 1 commit into from Apr 1, 2019

Conversation

cpirich
Copy link
Contributor

@cpirich cpirich commented Apr 1, 2019

  • These colors are referenced by the applab "dark" theme, under the applabThemes experiment. They were missed in the previous PR, probably because the apps/src/util/color.js file was modified locally, but they need to be in shared/css/color.scss

islemaster
islemaster approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we need a commit hook that notices when you've modified color.js instead of color.scss.

@cpirich cpirich merged commit 44fb135 into staging Apr 1, 2019
@cpirich cpirich deleted the cpirich/applab-theme-colors branch April 1, 2019 16:24
jmkulwik added a commit that referenced this pull request Jun 3, 2019
@jmkulwik
Revert "Merge pull request #27792 from code-dot-org/cpirich/applab-th…
2c45e5a 
…eme-colors"

This reverts commit 44fb135, reversing
changes made to 7efe289.
jmkulwik added a commit that referenced this pull request Jun 3, 2019
@jmkulwik
Revert "Merge pull request #27792 from code-dot-org/cpirich/applab-th…
3de1ea2 
…eme-colors"

This reverts commit 44fb135, reversing
changes made to 7efe289.
jmkulwik added a commit that referenced this pull request Jun 4, 2019
@jmkulwik
Revert "Revert "Merge pull request #27792 from code-dot-org/cpirich/a…
a0255aa 
…pplab-theme-colors""

This reverts commit 3de1ea2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islemaster islemaster islemaster approved these changes

@jmkulwik jmkulwik Awaiting requested review from jmkulwik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cpirich @islemaster