Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use webdrivers for managing local Selenium WebDrivers #27848

Merged
merged 1 commit into from Apr 8, 2019
Merged

Use webdrivers for managing local Selenium WebDrivers #27848

merged 1 commit into from Apr 8, 2019

Conversation

wjordan
Copy link
Contributor

@wjordan wjordan commented Apr 3, 2019 •
edited

This PR replaces the recently-deprecated chromedriver-helper with the webdrivers gem which is the recommended replacement.

The new gem also seamlessly provides the correct driver to Selenium in the background, so we need to maintain less glue code ourselves.

@wjordan wjordan changed the title Use webdriver for managing local chromedriver Use webdrivers for managing local Selenium WebDrivers Apr 8, 2019
islemaster
islemaster approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guitar_riff

@wjordan wjordan merged commit f693814 into staging Apr 8, 2019
@wjordan wjordan deleted the webdrivers branch April 8, 2019 23:07
@wjordan wjordan mentioned this pull request Apr 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islemaster islemaster islemaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wjordan @islemaster