Assessment UX Re-Design: Progress Bubble Tooltip #27862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
approved these changes
Apr 3, 2019
maddiedierker
approved these changes
Apr 3, 2019
| @@ -176,6 +178,7 @@ class ProgressBubble extends React.Component { | |||
| tooltipId={tooltipId} | |||
| icon={levelIcon} | |||
| text={tooltipText} | |||
| includeAssessmentIcon={levelIsAssessment} | |||
There was a problem hiding this comment.
nit: since we don't consume the value of levelIsAssessment anywhere else, we can call isLevelAssessment(level) like this:
Suggested change
| includeAssessmentIcon={levelIsAssessment} | |
| includeAssessmentIcon={isLevelAssessment(level)} |
and delete the assignment to levelIsAssessment on line 127
There was a problem hiding this comment.
So I had that thought and then left it like this because I'm probably going to need this variable to do some of the other assessment ux work such as adding the little check-circle in the corner of the bubble.
There was a problem hiding this comment.
ah, understandable! makes sense to leave it as-is then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in the mini rubric experiment and you hover over a level that is marked as an assessment you will see the check-circle icon in addition to the other icon for that level in the tooltip.
Before
After
In Experiment
Not in Experiment