Top Instructions CSP: Eyes Test #27903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epeach
approved these changes
Apr 5, 2019
davidsbailey
approved these changes
Apr 5, 2019
dashboard/test/ui/features/instructions/csp_top_instructions_eyes.feature
Show resolved
Hide resolved
davidsbailey
reviewed
Apr 5, 2019
dashboard/test/ui/features/instructions/csp_top_instructions_eyes.feature
Outdated
Show resolved
Hide resolved
davidsbailey
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not waiting for the code area of a web lab level to fully load before taking the eyes capture which was causing the test to be flaky. This will fix that problem by waiting for the editor area in web lab to fully load before capturing the screen.
Also update the weblab.feature test to drill one level deeper in the iframes to really make sure web lab loads.