PL: Regional partner search gets info about priority deadline dates #27924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regional partner search UI now gets an info box above each "start application" button related to a regional partner's upcoming regional priority deadline date. If there is such a date coming up, the viewer is told about it. If there is no such date, there is a fallback message. Because of the number of places in this code that we can show the "start application" button, it's now been factored out into a standalone stateless/functional React component.
|
@breville , Mark had some feedback on the new notifications and gave a new mock example with red lines. Notable changes are rounding, button formatting, and button moved to within notification. Can you change as mocked ? |
As well as code review feedback, this change unit tests the new priority deadline date field. It was interesting to discover that the unit tests failed when the local machine had its time zone set to something other than PST, and it turns out to be a known issue discussed at travisjeffery/timecop#182. The solution is to use `Date.current` rather than `Date.today`. A bunch of factories were also updated to use the yyyy-mm-dd date format that it turns out we're storing, as described in #27895
clareconstantine
approved these changes
Apr 9, 2019
| @@ -262,6 +262,8 @@ class RegionalPartnerTest < ActiveSupport::TestCase | |||
| assert_equal WORKSHOP_APPLICATION_STATES[:currently_open], regional_partner.summer_workshops_application_state | |||
| assert_equal "September 25, 2018", regional_partner.summer_workshops_earliest_apps_open_date | |||
| assert_nil regional_partner.link_to_partner_application | |||
|
|
|||
| assert_equal "October 2, 2018", regional_partner.upcoming_priority_deadline_date | |||
There was a problem hiding this comment.
is the extra space in there intentional?
There was a problem hiding this comment.
Good question. Yes, the use of the blank-padded day of the month (%e) goes back a couple years and we've just continued using it here.
| @@ -1017,10 +1017,10 @@ | |||
| contact_name "Contact Name" | |||
| contact_email "contact@code.org" | |||
| group 1 | |||
| apps_open_date_csp_teacher {Date.today - 1.day} | |||
There was a problem hiding this comment.
thanks for investigating and fixing all these tests!
clareconstantine
approved these changes
Apr 9, 2019
breville
deleted the
pl-priority-deadline-info-on-regional-partner-search
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regional partner search UI now gets an info box above each "start application" button related to a regional partner's upcoming regional priority deadline date. If there is such a date coming up, the viewer is told about it. If there is no such date, there is a fallback message.
Because of the number of places in this code that we can show the "start application" button, it's now been factored out into a standalone stateless/functional React component.
It was interesting to discover that the unit tests failed when the local machine had its time zone set to something other than PST, and it turns out to be a known issue discussed at travisjeffery/timecop#182. The solution is to use
Date.currentrather thanDate.today.A bunch of factories were also updated to use the yyyy-mm-dd date format that it turns out we're storing, as described in #27895
Upcoming priority deadline date
No upcoming priority deadline date
Button still working when linking to external partner site