Replace dangeroulsySetInnerHtml in Abuse error with UnsafeRenderedMarkdown #27928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
reviewed
Apr 8, 2019
|
@Hamms Yes, that's right. Will adding a style prop to the UnsafeRenderedMarkdown component so styles can be passed into the component be an option? |
|
Unfortunately, no; the paragraph elements these styles would be applied to are generated from the markdown rather than being developer-added React components to which we could apply the properties. |
islemaster
approved these changes
Apr 8, 2019
|
In that case, I'd recommend removing the property entirely so as not to be misleading |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abuse error message is shown when users attempt to open a project that is marked as abusive.
Before
After