Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete projects angular #27931

Merged
merged 1 commit into from Apr 8, 2019
Merged

Delete projects angular #27931

merged 1 commit into from Apr 8, 2019

Conversation

maddiedierker
Copy link
Contributor

Note: Change base back to staging before merging!

Follow-up for #27930

Nothing uses the /projects/angular route anymore, so I'm removing it!

@maddiedierker maddiedierker changed the base branch from staging to projects-dashboard-react April 8, 2019 19:02
Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup Maddie!

I'm not sure what all you are planning to tackle at this stage, but here is one instance that can be removed:

And here's one that might warrant follow-up. perhaps you have a better sense of the priority of doing so than I do:

@maddiedierker
Copy link
Contributor Author

thanks, @davidsbailey! i have both of those items on my list to tackle this week!

Copy link
Contributor

@Erin007 Erin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!!

@maddiedierker maddiedierker changed the base branch from projects-dashboard-react to staging April 8, 2019 23:04
@maddiedierker maddiedierker merged commit 2937e5b into staging Apr 8, 2019
@maddiedierker maddiedierker deleted the delete-projects-angular branch April 8, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants