Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assessment UX Re-design: Summary Progress View #27949

Merged
merged 28 commits into from Apr 10, 2019
Merged

Assessment UX Re-design: Summary Progress View #27949

merged 28 commits into from Apr 10, 2019

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Apr 9, 2019 •
edited

Summary Progress View

  • Tooltip includes assessment icon if the whole stage is all assessment levels
  • The progress bar shows up purple if the whole stage is all assessment levels

Before

Screen Shot 2019-04-09 at 9 54 40 AM

After

In Experiment

Screen Shot 2019-04-09 at 9 53 20 AM

Out of Experiment

Screen Shot 2019-04-09 at 9 54 40 AM

@dmcavoy
Merge branch 'staging' into assessment-ux-progress-bubble
66420dd
@dmcavoy
Turn a a bubble purple if marked as assessment
979c9bd
@dmcavoy
Levels that can be perfect or passed now turn purple if assessment
6e06ef1
@dmcavoy
Merge branch 'staging' into assessment-ux-progress-bubble
f4ba9c9
@dmcavoy
Merge branch 'staging' into assessment-ux-progress-bubble
e373f9e
@dmcavoy
Add assessment icon to all bubbles that are assessments
cbdd416
@dmcavoy
Put icon on bubble behind experiment. Don't show icon on progress view
3038163
@dmcavoy
Move purple bubble color behind experiment
79ecb8d
@dmcavoy
Stack icons and make sure there is a white border and background on a…
5e67b36 
…ssessment icon
@dmcavoy
Change level icon in detailed progress view header for assessment levels
b5acbde
@dmcavoy
Put progress view assessment icon behind experiment
ec60023
@dmcavoy
Update progressReduxTests with level status change
2e61c29
@dmcavoy
Add tests for ProgressBubble
1320aec
@dmcavoy
Add new level status of completed_assessment
f9d6de7
@dmcavoy
Add test for ProgressBubbleSet
ce47c2c
@dmcavoy
Add test for isLevelAssessment in progressHelpers
ef5a893
@dmcavoy
Trying to make the diff more readable for progressReduxTest
971a7cc
@dmcavoy
Add assessment icon to tooltip of lesson if entire lesson is assessme…
d2c1dfa 
…nt in progress view
@dmcavoy
Bubble turns purple for lesson that is all assessment in summary prog…
605bc45 
…ress view
@dmcavoy dmcavoy changed the base branch from staging to assessment-ux-progress-bubble April 9, 2019 14:07
davidsbailey
davidsbailey approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! one minor comment inline.

apps/src/templates/progress/progressHelpers.js Outdated Show resolved Hide resolved
maddiedierker
maddiedierker approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@maddiedierker maddiedierker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 great work, dani!

@dmcavoy dmcavoy changed the base branch from assessment-ux-progress-bubble to staging April 9, 2019 19:01
@dmcavoy dmcavoy merged commit 15f7784 into staging Apr 10, 2019
@dmcavoy dmcavoy deleted the assessment-ux-progress-view branch April 10, 2019 14:24
@maddiedierker maddiedierker mentioned this pull request Apr 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbailey davidsbailey davidsbailey approved these changes

@maddiedierker maddiedierker maddiedierker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmcavoy @davidsbailey @maddiedierker