Make it possible to render DSL levels without translations #27953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, all DSL levels depend on I18n.t to render their content, and will fall back to `nil` if they can't find the translation. We want to be able to only sync data into the translation system if we want to actually translate it, so we add the ability for DSL levels to fall back to the database content if they can't find translation data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, all DSL levels depend on I18n.t to render their content, and
will fall back to
nilif they can't find the translation. We want tobe able to only sync data into the translation system if we want to
actually translate it, so we add the ability for DSL levels to fall back
to the database content if they can't find translation data.
Originally added as part of #27881, which also includes changes to the way the DSL i18n data is synced. Extracted into this PR for a clearer division of concerns