Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deflake teacher dashboard when clicking student name to load new page #27963

Merged
merged 1 commit into from Apr 16, 2019

Conversation

davidsbailey
Copy link
Member

teacher dashboard ui tests have been failing like this lately: https://cucumber-logs.s3.amazonaws.com/test/test/Firefox45Win7_teacher_dashboard_output.html?versionId=eAxoLiS5khgaJSBakDNqULY9yhA_Kqye

The "too many connection resets" problem may be a symptom of starting a next UI test step too soon after the previous step performs an action which loads a new page. The solution is to use test steps ending in to load a new page, which wait for the old page to go away before continuing onto the next step.

Copy link
Contributor

@maddiedierker maddiedierker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix, dave! 🥇

@davidsbailey davidsbailey force-pushed the deflake-teacher-dashboard-student-click branch from d67f862 to fa19a9b Compare April 16, 2019 19:52
@davidsbailey davidsbailey merged commit 15f99a5 into staging Apr 16, 2019
@davidsbailey davidsbailey deleted the deflake-teacher-dashboard-student-click branch April 16, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants