Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Use reconfiguredChai.js in all of test/unit/code-studio #27993

Merged
merged 1 commit into from Apr 19, 2019

Conversation

islemaster
Copy link
Contributor

Uses reconfiguredChai.js instead of configuredChai.js in an entire subdirectory of tests.

Changes extracted from #27907 for only the apps/test/unit/code-studio directory and one associated utility file. See that PR for methodology. Just trying to break apart a potentially enormous project into ratchetable parts.

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏 Very cool!

Copy link
Contributor

@jmkulwik jmkulwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

Copy link
Contributor

@Erin007 Erin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wahoo! looks like great progress!

@islemaster islemaster merged commit 6bd8356 into staging Apr 19, 2019
@islemaster islemaster deleted the reconfigured-chai-code-studio branch April 19, 2019 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants