Mini Rubric: Expand the selected performance level for student by default #28008
Conversation
| @@ -263,7 +269,11 @@ export class TeacherFeedback extends Component { | |||
| <RubricField | |||
| key={level} | |||
| showFeedbackInputAreas={showFeedbackInputAreas} | |||
| expandByDefault={this.props.displayKeyConcept} | |||
| expandByDefault={ | |||
There was a problem hiding this comment.
this is calculation is getting pretty complex, so let's assign its value to a variable at the top of the render() method. something like:
const expandByDefault = this.props.displayKeyConcept || (expandPerformanceLevelForStudent && this.state.performance === level)
There was a problem hiding this comment.
similar to what you're doing for expandPerformanceLevelForStudent
There was a problem hiding this comment.
The level here comes from the map which is on the line right above <RubricField. In order to move this out I think I would need to make it a function. Should I do that?
There was a problem hiding this comment.
The level here comes from the map which is on the line right above <RubricField. In order to move this out I think I would need to make it a function. Should I do that?
There was a problem hiding this comment.
ah, sorry, i should've taken a closer look at the context here. in that case, it's fine to leave as-is
Expand the performance level the teacher gave to a student (if they gave them rubric feedback) by default when the student is looking at feedback.
Before
After