remove @chrome_before_62 and @no_older_chrome flags #28056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
force-pushed
the
remove-chrome-62
branch
from
913b91d
to
d4930ad
Compare
davidsbailey
commented
Apr 16, 2019
| @@ -32,7 +32,7 @@ Scenario: Fallback player for embedded | |||
| And I close my eyes | |||
|
|
|||
| # Starting in Chrome 62, sites can no longer automatically run plugins. | |||
| @chrome_before_62 | |||
| @no_chrome | |||
There was a problem hiding this comment.
I confirmed in https://drone.cdn-code.org/code-dot-org/code-dot-org/843/2/5 that this feature still does not work in latest chrome.
wjordan
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
See: #28048 (comment)
Description
Consolidate both flags into @no_chrome. This gives us parity with how things were operating when we ran Chrome44Win7, except that the one videoplayer feature is no longer run in Chrome 44 (but is still run in other browsers) during DTTs.