Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini Rubric: Rename Rubric Performance Levels #28069

Merged
merged 4 commits into from Apr 17, 2019
Merged

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Apr 17, 2019

The curriculum team wants to rename the rubric performance levels for mini rubrics from "Exceeds, meets, approaches, no evidence" to "Extensive Evidence, Convincing Evidence, Limited Evidence, No Evidence".

This change updates what is shown to teachers and students to meet those changes as well as changing the back end to make the names of the performance levels more generic so if we decide to change them again it is not confusing.

Questions/Concerns:

  • Maddie and I locally went through and found all the levels with mini_rubric = true and updates the properties names for the performance levels of the mini rubric. The level files are included here. Is that sufficient to make the change or do we need to do something on levelbuilder/production?
  • We have data in teacher_feedbacks on production which will contain a performance level with the old naming. All of that data should be from internal sources since we have not released the flag. Do we need to go in and fix up that data? What is the best way to do that if so?

Levelbuilder Edit Page

Screen Shot 2019-04-17 at 11 56 32 AM

Teacher

Screen Shot 2019-04-17 at 11 52 40 AM

Screen Shot 2019-04-17 at 11 53 27 AM

Student

Screen Shot 2019-04-17 at 11 52 40 AM

Screen Shot 2019-04-17 at 11 53 17 AM

CSV Download

Screen Shot 2019-04-17 at 12 00 26 PM

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Dani and Maddie! “Walking on water and developing software from a specification are easy if both are frozen.”

Maddie and I locally went through and found all the levels with mini_rubric = true and updates the properties names for the performance levels of the mini rubric. The level files are included here. Is that sufficient to make the change or do we need to do something on levelbuilder/production?

yes, that should be sufficient.

We have data in teacher_feedbacks on production which will contain a performance level with the old naming. All of that data should be from internal sources since we have not released the flag. Do we need to go in and fix up that data? What is the best way to do that if so?

No, because this data is only for internal users, it seems fine to just leave it how it is.

dashboard/app/models/script.rb Show resolved Hide resolved
Copy link
Contributor

@maddiedierker maddiedierker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇great refactor, dani!

@dmcavoy dmcavoy merged commit ece3803 into staging Apr 17, 2019
@dmcavoy dmcavoy deleted the rename-rubric-levels branch April 17, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants