Use jotform's iframe embed code #28087
Conversation
|
Does the monitoring added in #27764 still work? |
| // The setHeight message seems to be sent every time we load the form, so use this | ||
| // to fire the hook we are monitoring to indicate the iframe content has loaded. | ||
| // eslint-disable-next-line | ||
| JotFormFrameLoaded(); |
There was a problem hiding this comment.
@brad is it ok for the monitoring if this is called more than once per load?
There was a problem hiding this comment.
I think that would give us misleading stats about how often this happens. I'd fix this in jotformLoader.js though, where we listen for this call, and be resilient against multiple calls from either embed method in the future.
There was a problem hiding this comment.
Actually, I suppose that promise can't resolve twice... I wonder if it causes an error.
There was a problem hiding this comment.
It seems to resolve twice (or at least it logs the call twice)
There was a problem hiding this comment.
update - it only goes into the then once, so it only actually sends the load event to New Relic once, but it calls JotFormFrameLoaded (which does the console.log) twice.
There was a problem hiding this comment.
Cool, that answers the question. 👍
|
Got verbal confirmation from @islemaster that this is ready to ship! |
PLC-223
Based on JotForm's advice in this thread: https://www.jotform.com/answers/1786265-Embedded-form-load-failure-spiked-on-Saturday
Hopefully this reduces some of the mysterious issues with surveys not loading. I tested this manually and was able to submit forms, including a workshop daily survey, facilitator survey, and post-workshop survey.
cc: @agealy