Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable syncing dsls.en.yml with crowdin #28101

Merged
merged 1 commit into from May 17, 2019
Merged

Reenable syncing dsls.en.yml with crowdin #28101

merged 1 commit into from May 17, 2019

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Apr 19, 2019

Now that (as of #27881 and #27885) we are generating a version of that file that contains only the strings we know we want to translate, and as of #28548 we are also generating a version that includes contained levels.

Now that (as of #27881
and #27885) we are
generating a version of that file that contains only the strings we know
we want to translate
@Hamms
Copy link
Contributor Author

Hamms commented May 16, 2019

FYI @dju90

Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

Does this mean that in future i18n sync that we don't have to revert the dsls files?

@Hamms
Copy link
Contributor Author

Hamms commented May 16, 2019

Yep!!

@dju90
Copy link
Contributor

dju90 commented May 16, 2019

Awesome! 🎊

@Hamms Hamms merged commit 1930720 into staging May 17, 2019
@Hamms Hamms deleted the reenable-dsls-i18n branch May 17, 2019 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants