Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Applab theme values to match design, create screens in current theme #28232

Merged
merged 1 commit into from May 1, 2019
Merged

Update Applab theme values to match design, create screens in current theme #28232

merged 1 commit into from May 1, 2019

Conversation

cpirich
Copy link
Contributor

@cpirich cpirich commented Apr 26, 2019

  • I met with Mark yesterday to approve all of the theme values and debug issues in the redlines. The new values respect the latest from design.
  • The algorithm to set the initial button size (in design mode) has been adjusted to ensure either 80x30 (classic) or 100x40 (all new themes)
  • Based on Monday's bug bash, adjusted the behavior of creating new screens to choose the current theme instead of Default. This will ease the transition for existing Classic projects, as new screens will default to Classic. This also fixes a bug when duplicating screens - now the duplicated screen theme matches.

@cpirich cpirich requested a review from ajpal April 26, 2019 15:40
@cpirich
Copy link
Contributor Author

cpirich commented Apr 26, 2019

@ryansloan FYI

@joshlory
Copy link
Contributor

joshlory commented May 1, 2019

Follow up to PR #27914.

@ajpal ajpal merged commit 8fd4040 into staging May 1, 2019
@cpirich cpirich deleted the cpirich/applab-theme-design-updates branch May 1, 2019 22:33
jmkulwik added a commit that referenced this pull request Jun 3, 2019
@jmkulwik
Revert "Merge pull request #28232 from code-dot-org/cpirich/applab-th…
e25e665 
…eme-design-updates"

This reverts commit 8fd4040, reversing
changes made to 275aee6.
jmkulwik added a commit that referenced this pull request Jun 3, 2019
@jmkulwik
Revert "Merge pull request #28232 from code-dot-org/cpirich/applab-th…
ac482b4 
…eme-design-updates"

This reverts commit 8fd4040, reversing
changes made to 275aee6.
jmkulwik added a commit that referenced this pull request Jun 4, 2019
@jmkulwik
Revert "Revert "Merge pull request #28232 from code-dot-org/cpirich/a…
0a9f592 
…pplab-theme-design-updates""

This reverts commit ac482b4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajpal ajpal ajpal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpirich @joshlory @ajpal