Add is_stable to course #28275
Add is_stable to course #28275
Conversation
| # Any course with a plc_course or no family_name is considered stable. | ||
| # All other courses must specify an is_stable boolean property. | ||
| def stable_or_default | ||
| return true if plc_course || !family_name |
There was a problem hiding this comment.
should we consider version_year here at all, or is there an assumption that family_name ⇒ version_year?
There was a problem hiding this comment.
great question. so far from what i understand, we've been going on that assumption, but @davidsbailey might have more insight here
There was a problem hiding this comment.
depending on family_name seems fine for now. currently, the presence of family_name implies the presence of version year in the two courses that have family names, but there's nothing programmatically enforcing this. I'd say, go ahead with this for now and maybe later we can add some checks to enforce any assumptions.
dashboard/app/models/course.rb
Outdated
| @@ -55,6 +56,14 @@ def localized_version_title | |||
| I18n.t("data.course.name.#{name}.version_title", default: version_year) | |||
| end | |||
|
|
|||
| # Any course with a plc_course or no family_name is considered stable. | |||
| # All other courses must specify an is_stable boolean property. | |||
| def stable_or_default | |||
There was a problem hiding this comment.
Looks like a comment of mine disappeared -- this name seems confusing because it is redundant, because "default" means "latest stable". Can we call it stable? instead?
There was a problem hiding this comment.
yeah, good call! i'll update the naming now
Adds the
is_stableproperty to the Course model, and marks the following courses as stable: