Scholarship dropdowns set course #28278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breville
reviewed
Apr 30, 2019
| def self.update_or_create(user, application_year, scholarship_status) | ||
| scholarship_info = Pd::ScholarshipInfo.find_by(user: user, application_year: application_year) || Pd::ScholarshipInfo.new(user: user) | ||
| scholarship_info.update(scholarship_status: scholarship_status) | ||
| def self.update_or_create(user, application_year, course, scholarship_status) |
There was a problem hiding this comment.
At a certain number of parameters, a hash might be better? Not sure we're there yet, though...
breville
reviewed
Apr 30, 2019
| @@ -65,11 +65,13 @@ def update_user_school_info! | |||
| end | |||
|
|
|||
| def update_scholarship_status(scholarship_status) | |||
| Pd::ScholarshipInfo.update_or_create(user, application_year, scholarship_status) | |||
| Pd::ScholarshipInfo.update_or_create(user, application_year, course_name, scholarship_status) | |||
There was a problem hiding this comment.
Is course_name a user-friendly string (e.g. "CS Discoveries") or a short code (e.g. "csd")?
There was a problem hiding this comment.
user-friendly, so it matches the course we store for workshops.
There was a problem hiding this comment.
but based on your feedback here I'm going to switch to the simplfied course code ('csd')
hacodeorg
approved these changes
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of PLC-165
Now that we have added the
coursecolumn toScholarshipInfo, the existing scholarship dropdowns need to set it.