Fix markdown instructions in Star Wars #28386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The invalid markdown format we use here was invalidated in #27120 and wasn't caught by our "markdown conversion" project because it's in levels.js rather than levelbuilder
joshlory
approved these changes
May 6, 2019
| @@ -3555,44 +3555,47 @@ var js_hoc2015_event_free_markdown = [ | |||
| '', | |||
| '<details class="hoc2015">', | |||
| '<summary>Example project ideas</summary>', | |||
| '<p>**Example 1**', | |||
| '<p><strong>Example 1</strong>', | |||
There was a problem hiding this comment.
Markdown inside HTML isn't allowed with the new parser?
There was a problem hiding this comment.
correct. Specifically, content that should be parsed as HTML must be separated from content that should be parsed as Markdown with blank lines
See https://daringfireball.net/projects/markdown/syntax#html
|
Was this caught by Eyes tests, a user report, or something else? |
|
This was caught by me; an eyes test failed on this level for unrelated reasons, and I noticed this problem while looking at the level |
|
It would probably be worth spot-checking the other levels.js instructions; I think most of them tend to be pretty simple, though, so I wouldn't expect there to be similar violations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The invalid markdown format we use here was invalidated in
#27120 and wasn't
caught by our "markdown conversion" project because it's in levels.js
rather than levelbuilder