Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link to home on /lesson_plans #28417

Merged
merged 1 commit into from May 8, 2019
Merged

Fix broken link to home on /lesson_plans #28417

merged 1 commit into from May 8, 2019

Conversation

Erin007
Copy link
Contributor

@Erin007 Erin007 commented May 7, 2019

From code.org/lesson_plans there was a relative link to /home, which lives on studio.code.org so the link 404'ed.

Before:
home-link-lesson-plans

I used the CDO.studio_url helper to fix so now the home link goes to the correct page.

After:
home-link-lesson-plans-fixed

@Erin007 Erin007 added the bug-fix label May 7, 2019
@Erin007 Erin007 requested a review from breville May 7, 2019 23:20
@Erin007 Erin007 merged commit e53415d into staging May 8, 2019
@Erin007 Erin007 deleted the broken-home-link branch May 8, 2019 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants