Increase test coverage for user menu #28450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating LP-392, which references a Zendesk ticket wherein students seemingly are allowed to pair and have the link to do so in their user menu even though pairing is not allowed for the section in which they are members.
As part of the investigation I added a couple of cases to existing tests of the user_menu:
1.) students in a section with pairing allowed should see the pairing link
2.) students in a section with pairing not allowed should not see the pairing link
My next step is to look deeper at students in multiple sections and what happens when the pairing permissions of those sections conflict with one another.