Open-Url Block - Bug Fix for Over Quota #28465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpal
approved these changes
May 10, 2019
sureshc
reviewed
May 10, 2019
lib/cdo/safe_browsing.rb
Outdated
| @@ -52,6 +52,8 @@ def self.determine_safe_to_open(url_to_check) | |||
|
|
|||
| # Safe Browsing API returns empty JSON object is no threat matches found | |||
| # Do not determine safe if response is nil | |||
| response.nil? ? false : response_value | |||
| # Determine safe if bad request (response code is 400) or if rate-limited (429) | |||
| error_response = response.nil? ? false : (response.code === '400' || response.code === '429') | |||
There was a problem hiding this comment.
Is == more appropriate as a comparison operator here instead of ===?
I didn’t even realize Ruby had an === operator, so I had to look up how it’s used.
There was a problem hiding this comment.
Good call - I just defaulted to JavaScript equality at first. Updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we went over our quota for the api requests in our Open-Url Block. We requested (and got approved) for doubling our quota through Google Console. However, if this situation happens again, this PR should protect us by classifying responses returned as bad-requests or rate-limits as 'approved' to open. This means the user will receive a message letting them know what site they are going to and the user can make an informed choice.
Includes tests