Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import dataset at runtime if needed #28498

Merged
merged 3 commits into from May 13, 2019
Merged

Import dataset at runtime if needed #28498

merged 3 commits into from May 13, 2019

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented May 13, 2019

If you call getList with a table name that matches one of our provided datasets, but you haven't imported that dataset into your project yet, getList should import it silently.

@ajpal
Copy link
Contributor Author

ajpal commented May 13, 2019

I'll add unit tests for FirebaseStorage.importDataset in a future PR.

epeach
epeach approved these changes May 13, 2019
View reviewed changes
Copy link

@epeach epeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super familiar with this code, but LGTM

@ajpal ajpal merged commit 335bd7a into staging May 13, 2019
@ajpal ajpal mentioned this pull request May 14, 2019
Merged
@ajpal ajpal deleted the get-list-import branch May 16, 2019 03:46
jmkulwik added a commit that referenced this pull request Jun 26, 2019
@jmkulwik
Revert "Merge pull request #28498 from code-dot-org/get-list-import"
27f7e09 
This reverts commit 335bd7a, reversing
changes made to bb9ab94.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epeach epeach epeach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajpal @epeach