Populate column dropdown for getList #28509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epeach
reviewed
May 13, 2019
| }, | ||
| { | ||
| "name": "countries", | ||
| "description": "Information about different countries, images of their flags, and MP3 of their anthem", | ||
| "url": "/api/v1/dataset-library/countries.csv" | ||
| "url": "/api/v1/dataset-library/countries.csv", |
There was a problem hiding this comment.
Nit - some of these are captialized, some not. Nit for consistency, but not ship-blocking.
epeach
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-populate the dropdown for the second parameter of
getListwith the column names for the selected dataset. If the table name is not one of our sample datasets, no dropdown will show