Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research: gather data on accessible video player sites #28513

Merged
merged 1 commit into from May 14, 2019

Conversation

breville
Copy link
Member

Stop gathering the data we started in #21885.

@breville breville requested a review from islemaster May 13, 2019 21:27
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we delete that whole file, or is it still used elsewhere?

@breville
Copy link
Member Author

It's not used anywhere else, but I felt like it was useful enough that we might want to use some of it again someday. I'm neutral on whether to delete or not.

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, the reachability check is generally useful.

@breville breville merged commit df63dbb into staging May 14, 2019
@breville breville deleted the stop-gathering-video-site-accessibility-data branch May 14, 2019 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants