Reset all circuit playground components #28593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged code-dot-org/chrome-serial-app#2 and the new version (33) is now published to the Chrome Web Store.
|
islemaster
approved these changes
May 16, 2019
| if (components.accelerometer) { | ||
| components.accelerometer.stop(); | ||
| } | ||
| } |
There was a problem hiding this comment.
This seems correct. It'd be nice to deduplicate this code with destroyCircuitPlaygroundComponents, below.
|
Oh - tests please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not submit until code-dot-org/chrome-serial-app#2 is in. That PR fixes the remaining issues with sending too much at once across the wire. This change requires sending a bunch of commands across the wire to reset the state, so we need to fix the flakiness before submitting this.This is my attempt at resetting all state on each component. It was a little hard to track down some of the state, so if you can think of anything I may have missed please let me know! In particular, I'm a little worried that the sensors may still be sending readings across the wire, but I'm not sure how to check for this.