extract 'rename project' interface from ProjectHeader component into new EditableProjectName component #28600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new EditableProjectName component
islemaster
approved these changes
May 22, 2019
| } | ||
|
|
||
| dashboard.project.rename(newName, () => { | ||
| dashboard.header.updateTimestamp(); |
There was a problem hiding this comment.
Possible next steps: Can we remove these global dependencies by just importing project.js and header.js directly?
There was a problem hiding this comment.
oh, I had been thinking of reworking all of that to use redux internally, but just importing the files is way simpler!
Tracking here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #28461