Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script family cache #28683

Merged
merged 11 commits into from May 28, 2019
Merged

Script family cache #28683

merged 11 commits into from May 28, 2019

Conversation

maddiedierker
Copy link
Contributor

@maddiedierker maddiedierker commented May 21, 2019 •
edited

LP-345

Follow-up to #27999.

Script#get_from_cache will now raise an error if called with a family_name (i.e., it is present in ScriptConstants::FAMILY_NAMES) to avoid any future confusion and keep our caches organized!

@maddiedierker maddiedierker marked this pull request as ready for review May 22, 2019 19:28
islemaster
islemaster approved these changes May 22, 2019
View reviewed changes
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks correct to me.

@maddiedierker maddiedierker merged commit fa36c02 into staging May 28, 2019
@maddiedierker maddiedierker deleted the script-family-cache branch May 28, 2019 18:06
@wjordan wjordan mentioned this pull request Jan 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islemaster islemaster islemaster approved these changes

@davidsbailey davidsbailey Awaiting requested review from davidsbailey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maddiedierker @islemaster