Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add curriculum_umbrella to CSP scripts #28691

Merged
merged 1 commit into from May 22, 2019
Merged

Add curriculum_umbrella to CSP scripts #28691

merged 1 commit into from May 22, 2019

Conversation

Erin007
Copy link
Contributor

@Erin007 Erin007 commented May 22, 2019

Similar to #28689. Adds curriculum_umbrella 'CSP' to CSP scripts from all version years.

@davidsbailey
Copy link
Member

LGTM. There is a question as to whether the -staging scripts should be included, which ultimately depends on how curriculum_umbrella is going to be used. What I would suggest is, proceed with what you have here. and then whenever anyone wants to exclude the -staging scripts, they can do so by excluding those scripts which are still hidden. This approach gives feature owners the most flexibility with the least amount of hard-coding.

@Erin007 Erin007 merged commit 5172ccc into staging May 22, 2019
@Erin007 Erin007 deleted the add-curriculum-umbrella-to-csp branch May 22, 2019 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbailey davidsbailey davidsbailey approved these changes

@maddiedierker maddiedierker maddiedierker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Erin007 @davidsbailey @maddiedierker