Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete empty gradeX.script files #28693

Merged
merged 1 commit into from
May 30, 2019
Merged

Conversation

Erin007
Copy link
Contributor

@Erin007 Erin007 commented May 22, 2019

While working on #28689, I found empty scripts so I'm deleting them. Looks like they were WIP placeholders before Course A-F were settled on for CSF.
I think they are safe to delete because no one would have made progress in them since they were never live.

@Erin007
Copy link
Contributor Author

Erin007 commented May 22, 2019

I found a script to delete .script files from the db but it looks old. Do I still need to do that step?

@davidsbailey
Copy link
Member

Yes, if you're gonna delete these, please remove them from the database.

Scripts like this seem fine to delete as long as they were never "visible in teacher dashboard" a.k.a. never had hidden false in the script file.

@davidsbailey
Copy link
Member

quick update: since these scripts were blanked out 2.5 years ago and don't have anything left in them that could contain progress anyway, it seems fine to remove them without checking the history for whether they ever had hidden false.

@joshlory
Copy link
Contributor

Worth checking if there are any user levels that point to these Script IDs?

+1 for removing these from the production database as well! You could do a dry-run on staging or test.

@Erin007 Erin007 merged commit 2315f2e into staging May 30, 2019
@Erin007 Erin007 deleted the delete-empty-grade-scripts branch June 15, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants