Fix Inline Audio in non-english contained levels #28753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, make the InlineAudio component only attempt to derive the source file for a message string if it's actually given a message string. Right now, attempting to view a contained level with audis such as https://studio.code.org/s/express-2018/stage/14/puzzle/13 breaks in non-english locales because InlineAudio is attempting to perform an operation on a nonexistent string. This is expected to happen in situations where we don't have a translated audio string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, make the InlineAudio component only attempt to derive the
source file for a message string if it's actually given a message
string.
Right now, attempting to view a contained level with audis such as
https://studio.code.org/s/express-2018/stage/14/puzzle/13 breaks in
non-english locales because InlineAudio is attempting to perform an
operation on a nonexistent string. This is expected to happen in
situations where we don't have a translated audio string.
Reported at https://codeorg.zendesk.com/agent/tickets/240243