Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facilitator survey results use new roll-up questions #28842

Merged
merged 11 commits into from Jun 4, 2019

Conversation

clareconstantine
Copy link

@clareconstantine clareconstantine commented May 30, 2019

PLC-286
Spec - although the facilitator survey itself, not this spec, is now the source of truth.

Screen Shot 2019-05-30 at 3 51 05 PM

Copy link

@agealy agealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity, I believe the duplicated columns is an existing issue that we're not worrying about for now and can address for all affected dashboards in a future update.

Does the behavior of those columns change depending on user permissions, or is it dependent on the existence of other workshops hosted by that facilitator?

@clareconstantine
Copy link
Author

clareconstantine commented May 31, 2019

For posterity, I believe the duplicated columns is an existing issue that we're not worrying about for now and can address for all affected dashboards in a future update.

Does the behavior of those columns change depending on user permissions, or is it dependent on the existence of other workshops hosted by that facilitator?

@agealy it varies - the way it looks to people with other permissions is documented here: https://docs.google.com/document/d/1_1FtOKf-1A2zu6C8TjWzcjKWPnstP0NFeG57K79lzP8/edit

we only see the duplicate for workshop admins.

all_my_workshops: nil
},
# these values come from the average response to all questions in the category
# so, 4 / (category size)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh that's why!

# this, the QUESTIONS_FOR_FACILITATOR_AVERAGES contains a primary_id (what we use
# here) and optional all_ids (what is used in multiple forms)
# here) and optional all_ids (names used in multiple forms)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not specific to this PR, now we have a chance to re-do this facilitator survey, we should enforce a specific set of question names.

@hacodeorg
Copy link
Contributor

Looks good to me. IMO, there are so many hardcoded things in the UI layer that we should find a solution for later.

@clareconstantine clareconstantine merged commit 632c328 into staging Jun 4, 2019
@clareconstantine clareconstantine deleted the facilitator-survey-results branch June 19, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants