New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facilitator survey results use new roll-up questions #28842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For posterity, I believe the duplicated columns is an existing issue that we're not worrying about for now and can address for all affected dashboards in a future update.
Does the behavior of those columns change depending on user permissions, or is it dependent on the existence of other workshops hosted by that facilitator?
@agealy it varies - the way it looks to people with other permissions is documented here: https://docs.google.com/document/d/1_1FtOKf-1A2zu6C8TjWzcjKWPnstP0NFeG57K79lzP8/edit we only see the duplicate for workshop admins. |
all_my_workshops: nil | ||
}, | ||
# these values come from the average response to all questions in the category | ||
# so, 4 / (category size) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh that's why!
# this, the QUESTIONS_FOR_FACILITATOR_AVERAGES contains a primary_id (what we use | ||
# here) and optional all_ids (what is used in multiple forms) | ||
# here) and optional all_ids (names used in multiple forms) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not specific to this PR, now we have a chance to re-do this facilitator survey, we should enforce a specific set of question names.
Looks good to me. IMO, there are so many hardcoded things in the UI layer that we should find a solution for later. |
PLC-286
Spec - although the facilitator survey itself, not this spec, is now the source of truth.