PL: Submit misc surveys #28850
Merged
PL: Submit misc surveys #28850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breville
requested review from
clareconstantine,
agealy,
hacodeorg,
islemaster and
bencodeorg
Conflicts: dashboard/lib/pd/jot_form/constants.rb
agealy
approved these changes
May 31, 2019
hacodeorg
reviewed
May 31, 2019
hacodeorg
reviewed
Jun 1, 2019
|
This PR looks good to me! Please add some basic tests when you can. |
islemaster
approved these changes
Jun 1, 2019
|
|
||
| if CDO.newrelic_logging | ||
| NewRelic::Agent.record_custom_event( | ||
| "RenderJotFormView", |
There was a problem hiding this comment.
🎉 Thanks for remembering to include this!
hacodeorg
reviewed
Jun 3, 2019
hacodeorg
reviewed
Jun 3, 2019
hacodeorg
reviewed
Jun 3, 2019
| # Update answers for this submission from the JotForm API | ||
| # Useful for filling in placeholder response entries (submission id but no answers) | ||
| def sync_from_jotform | ||
| raise 'Missing submission id' unless submission_id.present? | ||
|
|
||
| submission = JotForm::Translation.new(form_id).get_submission(submission_id) | ||
| update!(answers: submission[:answers].to_json) | ||
| questions_details = self.class.use_names_for_question_ids? ? JSON.parse(questions.questions) : nil |
There was a problem hiding this comment.
this means question_details only available if use_names_for_questions_ids is true? Does that affect syncing other forms?
There was a problem hiding this comment.
The questions parameter in process_answers_from_submission is optional, and again only attempted to be used when use_names_for_question_ids? is true.
hacodeorg
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the work in #28703 to allow the hosted submission of a misc survey.
Usage is designed to be largely self-serve: direct users to a URL such as https://studio.code.org/pd/misc_survey/other_workshop, and the matching JotForm survey will be embedded. As it happens, this URL is the first form we're going to use with this system: the Unofficial Workshop Attendance form. (And while it's mostly self-serve, there is for now a table in
Pd::MiscSurveyspecifying the form ID, its mapping to a URL, and that it can be embedded.)Following normal practices, the form is set up in JotForm to have a hidden
submitRedirectfield which takes the URL we pass it, and upon user submission, POSTs to that URL, which submits to our new controller. The controller is set up to only allow one submission per form ID per user, and to restrict submission to teacher accounts with email. If the teacher is missing a school, the interstitial will pop up, encouraging them to enter one first. (Longer term, these requirements should be configurable per form.)The new form has a JotForm
datetimecontrol, and so this change adds support for that answer type. We treat this result specially and translate the incoming hash into a string in the answers like this:Because the form is embedded on our site, a placeholder entry is added to
Pd::MiscSurveyupon submission, and then thefill_jotform_placeholderscron job fills the entry shortly afterwards. Thesync_jotformscron job will continue to retrieve additional submissions which didn't get a placeholder for some reason.It turns out that there are different codepaths in
Pd::JotFormBackedFormfor writing the answers in each of these cases, and so theprocess_answers_from_submissionfunction has been added to factor out the work of storing the answers usingnameinstead ofidkeys when possible.The form
Interstitial when missing school
When signed out
When not a teacher
When teacher missing email