Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crowdin refactor impl #28904

Merged
merged 3 commits into from Jun 4, 2019
Merged

Crowdin refactor impl #28904

merged 3 commits into from Jun 4, 2019

Conversation

bethanyaconnor
Copy link
Contributor

Fully aware that this code could definitely be prettier and some redaction/restoration code could be shared. This is more quick and dirty to unblock the refactor.

@bethanyaconnor bethanyaconnor requested a review from Hamms June 3, 2019 23:32
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you add a Jira item to track cleaning this up?

@bethanyaconnor
Copy link
Contributor Author

@bethanyaconnor bethanyaconnor merged commit ccfaac6 into staging Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants