Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the help button on small screens #28951

Merged
merged 3 commits into from Jun 10, 2019
Merged

Conversation

bethanyaconnor
Copy link
Contributor

@bethanyaconnor bethanyaconnor commented Jun 5, 2019

Jira

On small screens, add the help options into the hamburger menu and hide the help button.
Screenshot 2019-06-05 at 6 04 55 PM

@Erin007
Copy link
Contributor

Erin007 commented Jun 6, 2019

The code changes look good, but I have some initial reservations about hiding the help icon on mobile. It seems like having the help icon hidden on mobile could be confusing. The whole point of that icon is to make it easier for users - arguably are most frustrated users - to find the help that they need and if I know how to find those links on desktop because we've made it more obvious (yay!), I'm going to be confused and even more frustrated if the help links aren't where I expect them to be on mobile.

I wonder if we can make the header feel less cluttered by moving the code logo and the hamburger to align with contents of the page on mobile.
help icon mobile

@dju90 did ya'll already discuss and decide against this option?

Copy link
Contributor

@Erin007 Erin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience @bethanyaconnor while I got more details about the design!

@bethanyaconnor
Copy link
Contributor Author

Thanks Erin for raising these questions!

@bethanyaconnor bethanyaconnor merged commit df9c443 into staging Jun 10, 2019
@bethanyaconnor bethanyaconnor deleted the help-button-improvements branch March 17, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants