Fix I18n UI test #29022
Merged
Fix I18n UI test #29022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The I18n restructure included a shift away from generic two-letter keys in the i18n system to more-specific four-letter keys. This had no user-impacting change, but did break some UI tests where we were hardcoding the two-letter version. Simply updating to four-letter keys in the tests fixes this.
davidsbailey
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The I18n restructure included a shift away from generic two-letter keys
in the i18n system to more-specific four-letter keys. This had no
user-impacting change, but did break some UI tests where we were
hardcoding the two-letter version.
Simply updating to four-letter keys in the tests fixes this.