return 404 when stage extras for an unversioned course url are requested #29043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddiedierker
approved these changes
Jun 10, 2019
glad to know there wasn't any user impact here, too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Fixes https://app.honeybadger.io/projects/3240/faults/50002356
Investigation into the honeybadger error revealed that they all had one of the following two settings in the "parameters" section:
Internet research revealed that these search engine crawlers will keep requesting urls that return a 5xx, and need to receive a 404 or 410 in order to be told to stop requesting them.
Description
Return 404 for any request to an unversioned stage extras url such as those listed in the honeybadger events.