Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teacher Panel Iterator Take 2 #29049

Merged
merged 2 commits into from Jun 11, 2019
Merged

Teacher Panel Iterator Take 2 #29049

merged 2 commits into from Jun 11, 2019

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Jun 11, 2019

Re-implements #28967 but fixes an issue with the view as student mode.

Issue: View as student mode showed teacher example solutions (in production) and selected student info (not in production - was bug in new code)

Before

59230517-871fb900-8b92-11e9-8141-5eb4192e9810

Screen Shot 2019-06-11 at 10 11 57 AM

After

Screen Shot 2019-06-11 at 10 10 26 AM

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice quick fix!

@dmcavoy dmcavoy merged commit e6b4303 into staging Jun 11, 2019
@dmcavoy dmcavoy deleted the teacher-panel-iterator-2 branch June 11, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants