Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncomment school seeding #29061

Merged
merged 2 commits into from Jun 11, 2019
Merged

Uncomment school seeding #29061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7121615
Uncomment full seeding for schools and school districts
bencodeorg Jun 11, 2019
a620f80
Uncomment check for environment seeding variable
bencodeorg Jun 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 2 additions & 6 deletions dashboard/app/models/school.rb
View file
Open in desktop
Expand Up @@ -99,12 +99,8 @@ def self.seed_all(options = {})
School.transaction do
merge_from_csv(schools_tsv)
end
# this also needs to be commented out to prevent seeding
# of new schools until school_districts table is updated
# b/c we'll get foreign key errors if this were to be executed
# (i.e., schools added without appropriate school districts)
# else
# School.seed_from_s3
else
School.seed_from_s3
end
end

Expand Down
7 changes: 2 additions & 5 deletions dashboard/app/models/school_district.rb
View file
Open in desktop
Expand Up @@ -43,11 +43,8 @@ def self.seed_all(options = {})
SchoolDistrict.transaction do
merge_from_csv(school_districts_tsv)
end
# Temporarily commenting out the case where we run the full seed_from_s3
# (i.e., in production) in order to separately run seed_from_s3
# manually so as not to slow down the production deploy.
# else
# SchoolDistrict.seed_from_s3
else
SchoolDistrict.seed_from_s3
end
end

Expand Down