Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applab: prevent students from creating element ids with spaces #29063

Merged
merged 7 commits into from Jun 13, 2019

Conversation

jmkulwik
Copy link
Contributor

@jmkulwik jmkulwik commented Jun 11, 2019

ids on HTML elements should not have spaces (Living HTML spec). This prevents students from adding spaces to their elements while in design mode. Additionally, if they create an element in code mode with a space, it will warn them. Also fixes this bug: https://codedotorg.atlassian.net/browse/STAR-412
image

@jmkulwik jmkulwik changed the title Remove spaces from ids When removing spaces from element IDs, check for reserved words Jun 11, 2019
@jmkulwik jmkulwik changed the title When removing spaces from element IDs, check for reserved words Applab: prevent students from creating element ids with spaces Jun 12, 2019
Copy link

@epeach epeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tests are awesome! 🎉

@jmkulwik jmkulwik merged commit 78fad72 into staging Jun 13, 2019
@jmkulwik jmkulwik deleted the remove-spaces-from-ids branch August 9, 2019 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants