Measure contact rollups job #29073
Merged
Measure contact rollups job #29073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacodeorg
requested review from
islemaster,
sureshc,
clareconstantine and
breville
breville
reviewed
Jun 12, 2019
breville
reviewed
Jun 12, 2019
agealy
approved these changes
Jun 12, 2019
clareconstantine
approved these changes
Jun 12, 2019
islemaster
reviewed
Jun 13, 2019
islemaster
reviewed
Jun 13, 2019
islemaster
approved these changes
Jun 13, 2019
sureshc
reviewed
Jun 17, 2019
| require 'cdo/log_collector' | ||
|
|
||
| class LogCollectorTest < Minitest::Test | ||
| def test_time_a_function |
There was a problem hiding this comment.
Can we use TimeCop to test that LogCollector correctly measures the amount of time it took the function to execute?
There was a problem hiding this comment.
Will keep this idea for future improvement.
I'm looking at examples of Timecop in our code base; 2 common functions areTimecop.freeze(time) and Timecop.travel and it is not obvious to me how to measure execution time?
There was a problem hiding this comment.
Makes sense. I think we could freeze time before invoking a method that is wrapped in the log collector, and inside the wrapped method we could travel forward. That might enable us to assert that the log collector correctly measured how much time elapsed during execution.
sureshc
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLC-258
What
cron-dailySlack channel (example).Why
How tested
bundle exec ruby lib/test/cdo/test_log_collector.rbtestserverscreensection so job will still run even connection to test server breaks.bin/cron/build_contact_rollups.ctrl+a+d, resume section =screen -r <sessions_name>, list =screen -ls)Note
I add all PLC to this PR since Contact Rollups is in PLC land now and anyone of us may have to work on it in the future.
TO DO