Refactor Redirect Dialog for Open Block #29076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlory
approved these changes
Jun 12, 2019
| const styles = { | ||
| title: { | ||
| display: 'inline', | ||
| wordWrap: 'break-word' |
|
From what I can tell, the other redirect dialog is used for redirecting students to different versions of scripts, so only redirecting within the code.org world, where as this one redirects folks outside of code.org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two RedirectDialog components. This PR renames one as ExternalRedirectDialog - this is the dialog that is called when a student uses the open block in AppLab. This PR also updates the ExternalRedirectDialog story and wraps the url of very long links.