Add storybook for TopInstructions #29083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erin007
reviewed
Jun 12, 2019
| paddingLeft: 12 | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
yeah! Thanks for including these styles. RTL doesn't get enough love on our site
Erin007
reviewed
Jun 12, 2019
| export default storybook => { | ||
| const stories = storybook.storiesOf('TopInstructions', module); | ||
|
|
||
| Object.entries(STORIES).forEach(([name, options]) => { |
There was a problem hiding this comment.
oh I like this set up - I don't think I've seen it before, but seems tidier than writing the stories out individually and passing different props combos
There was a problem hiding this comment.
Can't take credit for it - copied the setup that existed for InstructionsCSF
Erin007
approved these changes
Jun 12, 2019
maddiedierker
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a storybook for TopInstructions. There are still some features I would like to see added in the future but this covers the major areas.
Also move the audio button to the left side when in RTL for CSD/CSP since I saw that issue while using storybook.