unit tests for sprite map and getSpriteArray() #29088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmkulwik
reviewed
Jun 12, 2019
| @@ -0,0 +1,100 @@ | |||
| /* global p5 */ | |||
| import {expect} from '../../../util/configuredChai'; | |||
There was a problem hiding this comment.
use ../../../util/reconfiguredChai since configuredChai contains a module that is being deprecated.
jmkulwik
reviewed
Jun 12, 2019
|
|
||
| describe('Sprite Utils', () => { | ||
| let gameLabP5, createSprite, animation; | ||
| // Using the aggressive sandbox here because the P5 library generates |
There was a problem hiding this comment.
I'm not entirely sure, I was using GameLabSpriteTest as a guide. But it doesn't seem to be necessary so I deleted it.
jmkulwik
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test coverage for
getSpriteArray(),getAnimationsInUse(),getSpriteIdsInUse(),addSprite(),deleteSprite()and indirectly for private functionallSpritesWithAnimation()