Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set extraArgs.target correctly #29098

Merged
merged 1 commit into from Jun 13, 2019
Merged

Set extraArgs.target correctly #29098

merged 1 commit into from Jun 13, 2019

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented Jun 13, 2019

Was accidentally setting extraArgs.target to sprite.id, not target.id. This causes problems if you try to use other sprite in the event block.

jmkulwik
jmkulwik approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@jmkulwik jmkulwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@ajpal ajpal merged commit 83ba851 into staging Jun 13, 2019
@ajpal ajpal deleted the spritelab-sim-bug branch June 13, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmkulwik jmkulwik jmkulwik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajpal @jmkulwik