Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Use reconfiguredChai in more places #29247

Merged
merged 9 commits into from Jun 20, 2019
Merged

Tests: Use reconfiguredChai in more places #29247

merged 9 commits into from Jun 20, 2019

Conversation

islemaster
Copy link
Contributor

We're in the process of switching over to using a reconfiguredChai.js helper that omits chai-enzyme. As we're so close to switching to Enzyme 3, we might as well get through most of this cleanup as well. Here I've switched a bunch of remaining uses of the old configuredChai helper in test files owned by LP or PLC over to either reconfiguredChai or vanilla chai as needed.

@islemaster
Copy link
Contributor Author

Merging without review - this is a super-boring refactor 100% validated by passing tests.

@islemaster islemaster merged commit f753db3 into staging Jun 20, 2019
@islemaster islemaster deleted the more-reconfiguredChai branch June 20, 2019 18:19
jmkulwik added a commit that referenced this pull request Jun 25, 2019
@jmkulwik
Revert "Merge pull request #29247 from code-dot-org/more-reconfigured…
2402e43 
…Chai"

This reverts commit f753db3, reversing
changes made to 3732e52.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshlory joshlory Awaiting requested review from joshlory

@jmkulwik jmkulwik Awaiting requested review from jmkulwik

Assignees
No one assigned
Labels
code-hygiene testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@islemaster