New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sprite Lab event tests #29268
Sprite Lab event tests #29268
Conversation
spriteId = spriteUtils.addSprite(sprite); | ||
target = createSprite(); | ||
targetId = spriteUtils.addSprite(target); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: remove newline
mouseIsOverStub.restore(); | ||
mousePressedOverStub.restore(); | ||
}); | ||
it('works with individual sprites', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: 'work with individual sprites'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with others below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why "work"? I was trying to make it read like "it works with..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Had a couple nits in there. No need for a second review if you do/don't change them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
Test coverage for click, key, and collision events in Sprite Lab
Follow up- will add more test coverage for costume group collisions as part of https://codedotorg.atlassian.net/browse/STAR-537