Preload Sprite Lab background images #29358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmkulwik
reviewed
Jun 27, 2019
| return new Promise(resolve => { | ||
| backgrounds.forEach(background => { | ||
| this.p5.loadImage(background.sourceUrl, image => { | ||
| this.p5._predefinedBackgrounds[background.legacyParam] = image; |
There was a problem hiding this comment.
Will this still work if there is no legacyParam? i.e. if we add more background images
There was a problem hiding this comment.
Also, worth adding a test?
There was a problem hiding this comment.
If we add more background images, then we will need additional logic to key by name in those cases. I think it's fine to hold off on adding that until we actually add new images, though.
jmkulwik
reviewed
Jun 27, 2019
| let backgroundImage = this.loadImage(img); | ||
| backgroundImage.name = img; | ||
| spriteUtils.background = backgroundImage; | ||
| if (this._predefinedBackgrounds[img]) { |
There was a problem hiding this comment.
Two questions:
- Should there be an else here?
- Do we use loadImage anywhere anymore?
There was a problem hiding this comment.
- No, I think we decided yesterday not to try to live-load the image if we don't have it preloaded. That case should never come up, so it would basically just be untested/unused code. The image parameter can only be set by the values in the dropdown, so as long as we have all of those images preloaded, we will never reach an else case.
loadImageis only called during the preload stage now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change preloads the background images in the dropdown for the
setBackgroundImageblock in the preload phase of the P5 lifecycle. This change is necessary to show the background images in preview mode.Old:
New:
Currently, the
namefield inbackgrounds.jsonis unused, since thesetBackgroundImageblock uses explicit URLs (thelegacyParamfield inbackgrounds.json). Ideally, over the longterm, we can make a plan to migrate the block XML for that block, and then use thenamefield instead oflegacyParam