Sanitize XML #29454
Merged
Sanitize XML #29454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanitize XML in Markdown to allow only those tags and attributes we need for Blockly. Note that this list was generated based on an analysis of the Blockly XML we _currently_ use, not on all the possible XML we _could_ use. It could be that this list is inadequately permissive.
nkiruka
approved these changes
Jul 2, 2019
bethanyaconnor
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanitize XML in Markdown to allow only those tags and attributes we need for Blockly.
Note that this list was generated based on an analysis of the Blockly XML we currently use, not on all the possible XML we could use. It could be that this list is inadequately permissive, but it can easily be updated moving forward.